Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bugfix: test saturation values for table order. #4144

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

atgeirr
Copy link
Member

@atgeirr atgeirr commented Jul 19, 2024

As discussed in #4081, fixing a bug potentially turning the saturation tables.

@atgeirr
Copy link
Member Author

atgeirr commented Jul 19, 2024

jenkins build this please

@atgeirr
Copy link
Member Author

atgeirr commented Jul 24, 2024

The high number of test failures is a bit disheartening, but on the other hand the interpolation seems to be robust with respect to the order of the saturation values, so it should not matter significantly (i.e. getting wrong results) if order is flipped or not.

@blattms
Copy link
Member

blattms commented Jul 25, 2024

What does the Sw stand for?

@atgeirr
Copy link
Member Author

atgeirr commented Jul 25, 2024

What does the Sw stand for?

I think in this particular context it should probably be just s, for saturation. While not 100% sure of the lineage of the code it probably stood for "saturation, wetting" in the original context. Which of course is very easy to confuse with water saturation.

@blattms
Copy link
Member

blattms commented Jul 25, 2024

So values is the input to the tabulated functions and Swvalues are used for interpolate the the result for a particular value.

@atgeirr
Copy link
Member Author

atgeirr commented Jul 25, 2024

So values is the input to the tabulated functions and Swvalues are used for interpolate the the result for a particular value.

This class gives a function f(x) by piecewise linear interpolation, where the (x_i, f(x_i)) data are (swValues[i], values[i]). Which is maybe what you said, but I was not sure...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants